Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

Rolf Eike Beer kde at opensource.sf-tec.de
Thu Jul 20 22:05:44 BST 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130193/#review103463
-----------------------------------------------------------


Ship it!




While at it, please also remove the arguments from the else() and endif() calls.

- Rolf Eike Beer


On Juli 20, 2017, 7:59 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130193/
> -----------------------------------------------------------
> 
> (Updated Juli 20, 2017, 7:59 nachm.)
> 
> 
> Review request for kdelibs and Frank Osterfeld.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Otherwise it errors out with:
> "CMake Error at kdeui/CMakeLists.txt:316 (else): A duplicate ELSE
> command was found inside an IF block."
> Also adjust indentation to match the surrounding lines.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt d6ec8b47e9af686441ab5ab761be9ff424cbb556 
> 
> Diff: https://git.reviewboard.kde.org/r/130193/diff/
> 
> 
> Testing
> -------
> 
> Builds fine with cmake-3.9.0.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170720/4d3fed39/attachment.htm>


More information about the kde-core-devel mailing list