AtCore on KDE Review

[Lays Rodrigues]

Well, choosed to maintain the translation.
Diff with the script merged:
https://phabricator.kde.org/D6692

Thanks Luigui!

On Wed, Jul 12, 2017 at 6:36 PM, Lays Rodrigues <
laysrodriguessilva at gmail.com> wrote:

>
>
> On Wed, Jul 12, 2017 at 9:30 AM, Luigi Toscano <luigi.toscano at tiscali.it>
> wrote:
>
>> On Wednesday, 12 July 2017 14:19:29 CEST you wrote:
>> > I don't see the importance to add a translation to AtCore Test Client
>> since
>> > Atelier should be the main client (in one month or two).
>> > The test client is only for testing.
>>
>> There are ::tr calls also in
>> src/gcodecommands.cpp:
>>
>> and one inside src/atcore.cpp, but it's in a qCDebug and should most
>> likely be
>> removed.
>>
> ​Diff opened to solve this:
> https://phabricator.kde.org/D6651​
>
>
>>
>> --
>> Luigi
>>
>
>
>
> --
> *Lays Rodrigues*
> *Software Developer at KDE*
> *Intern at Rede Globo*
> *Computer Science student at Federal Fluminense University*
> *laysrodriguesdev.wordpress.com <http://laysrodriguesdev.wordpress.com>*
> *Telegram: @lays147*
> *IRC: lays147*
> *Phone: +55 22 981520012 <+55%2022%2098152-0012>*
>



-- 
*Lays Rodrigues*
*Software Developer at KDE*
*Intern at Rede Globo*
*Computer Science student at Federal Fluminense University*
*laysrodriguesdev.wordpress.com <http://laysrodriguesdev.wordpress.com>*
*Telegram: @lays147*
*IRC: lays147*
*Phone: +55 22 981520012*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170713/937ff070/attachment.htm>