Review Request 114437: Add right click contextmenu for Plasma Components TextField

Albert Astals Cid aacid at kde.org
Mon Jan 23 23:14:28 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114437/#review102234
-----------------------------------------------------------



Mr Leszek, I'm very sorry we failed to commit this 3 years ago when you proposed this patch.

On the other hand you never answered Burkhard about his very valid concern of the new strings you're adding being basically untraslatable because they are not extracted to any .po file (and probably no catalog to translate them is loaded either).

I'll give you some time to address that issue, but I can understand that you may very well not be interested anymore. If nothing has happened to this review request in 3 months I'll discard it.

- Albert Astals Cid


On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114437/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 3:37 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text. 
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f 
> 
> Diff: https://git.reviewboard.kde.org/r/114437/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leszek Lesner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170123/ed9ab24b/attachment.htm>


More information about the kde-core-devel mailing list