Review Request 129917: Add a cache monitor to the System Load Viewer applet

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102567
-----------------------------------------------------------



Sebas can this be commited now or you have more concerns?

- Albert Astals Cid


On Feb. 7, 2017, 9:20 a.m., Pascal VITOUX wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 9:20 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with the maximal amount reached, until the remaining dirty amount goes below a minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a slow storage device like a USB drive.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> -------
> 
> I use it since several months without issue.
> 
> 
> File Attachments
> ----------------
> 
> panel applets : circular, bar and compact bar monitors
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
> desktop applet, with tooltip
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
> desktop applet, circular monitors
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170221/b52a86a6/attachment.htm>