Review Request 108862: QML Plasma Components: improve positioning strategy for inline dialog

[Sebastian Gottfried]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108862/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 12:42 p.m.)


Status
------

This change has been discarded.


Review request for KDE Runtime and Marco Martin.


Repository: kde-runtime


Description
-------

This changes the positioning of the inline dialog in two ways:

1) Offset the dialog vertically so the balloon tip won't poke into the visual parent.

2) Make sure the dialog won't leave the view port in the horizontal dimension. This useful for dialogs with parents near the viewport border. The position of the tip is adjusted appropriately.

I'm not sure whether this still a bugfix or not and should also go into KDE/4.10. Please comment.


Diffs
-----

  plasma/declarativeimports/plasmacomponents/qml/private/InlineDialog.qml 2b7b832 

Diff: https://git.reviewboard.kde.org/r/108862/diff/


Testing
-------

Tested within KTouch. Works as expected.


File Attachments
----------------

Improved positioning
  https://git.reviewboard.kde.org/media/uploaded/files/2013/02/08/improved-inline-dialog-positioning.png


Thanks,

Sebastian Gottfried

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170208/0df60a04/attachment.htm>