Review Request 129917: Add a cache monitor to the System Load Viewer applet

[Pascal VITOUX]

> On fév. 5, 2017, 2:52 après-midi, Dominik Haumann wrote:
> > Essentially, the idea is good I think. Just tested this patch, and what I get looks like this: https://ibin.co/3BLqYW18K8p4.png
> > In the "Compact Bar" mode, there are two bars for the cache monitors, and the right one paints over the clock.
> > 
> > Is it maybe that you wanted hals the width in compact bar mode? This certainly needs to be fixed in any case.

The two values (dirty and writeback) are supposed to be stacked in the same bar. In your capture the first empty bar should be for the swap monitor.

However, there was indeed an issue with the applet width but only when using the 'CPUs separately' option.


- Pascal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102413
-----------------------------------------------------------


On fév. 5, 2017, 7:11 après-midi, Pascal VITOUX wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> -----------------------------------------------------------
> 
> (Updated fév. 5, 2017, 7:11 après-midi)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with the maximal amount reached, until the remaining dirty amount goes below a minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a slow storage device like a USB drive.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> -------
> 
> I use it since several months without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170205/3552a2d6/attachment.htm>