Review Request 130239: Exclude kconf_update from catching by uac on Windows

Alexey Min alexey.min at gmail.com
Tue Dec 26 13:06:59 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130239/#review103848
-----------------------------------------------------------


Ship it!




Ship It!

- Alexey Min


On Сен. 27, 2017, 9:19 д.п., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130239/
> -----------------------------------------------------------
> 
> (Updated Сен. 27, 2017, 9:19 д.п.)
> 
> 
> Review request for kdelibs and Albert Astals Cid.
> 
> 
> Bugs: 384334
>     http://bugs.kde.org/show_bug.cgi?id=384334
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch fixes an issue that on the first start of KMyMoney (and on some computers on every start for example reported by https://forum.kde.org/viewtopic.php?f=69&t=141673&sid=ba4dcaa26018f16e19d21c58c34ad4e9) on running kconf_update the user account control pops up and forces the user to allow or deny  this application.
> 
> Commit message
> 
>    Add Windows manifest to  kconf_update.exe
>     
>     This explicitly sets the execution level to 'asInvoker', preventing
>     Windows' UAC heuristics from deciding that because its name mentions
>     "update", it probably needs to escalate privileges.
>     
>     FIXED-IN:4.14.36
>     BUG:384334
> 
> 
> Diffs
> -----
> 
>   kconf_update/CMakeLists.txt 6bf3bf1f923baf11aad63e10fe249d70ce1b4d33 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130239/diff/3/
> 
> 
> Testing
> -------
> 
> Compiled at https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4 and tested with KMyMoney snapshot for Windows downloadable from https://software.opensuse.org/package/mingw32-kmymoney-portable
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20171226/ed64c838/attachment.htm>


More information about the kde-core-devel mailing list