imagewriter in kdereview

[Albert Astals Cid]

El dilluns, 10 d’abril de 2017, a les 17:41:17 CEST, Jonathan Riddell va escriure:
> On 8 April 2017 at 17:22, Albert Astals Cid <aacid at kde.org> wrote:
> > El divendres, 7 d’abril de 2017, a les 15:21:20 CEST, Jonathan Riddell va
> > 
> > escriure:
> >> Please review imagewriter which I've just had moved to kdereview.
> > 
> > It doesn't build https://paste.kde.org/p4mj6bgms
> 
> Spooky.  Fixed.
> 
> > Also i find that imagewriter is a bit "too generic", maybe
> > iso-imagewriter?
> 
> I've renamed it now to isoimagewriter.  But now KAuth doesn't like it, sigh.

Because of this?

./imagewriter/maindialog.cpp:330:    KAuth::Action action(QLatin1String("org.kde.imagewriter.writefile"));
./imagewriter/maindialog.cpp:331:    action.setHelperId("org.kde.imagewriter");
./imagewriter/CMakeLists.txt:18:    imagewriter.cpp
./imagewriter/testy.cpp:53:    KAuth::Action action(QLatin1String("org.kde.imagewriter.writeimage"));
./imagewriter/testy.cpp:54:    action.setHelperId("org.kde.imagewriter");
./imagewriter/testy.cpp:78:    KAuth::Action action(QLatin1String("org.kde.imagewriter.writeimage"));
./imagewriter/testy.cpp:79:    action.setHelperId("org.kde.imagewriter");
./imagewriter/testy.cpp:171:    KAuth::Action action(QLatin1String("org.kde.imagewriter.writefile"));


Also ./Messages.sh seems to not have been updated

And also there's a ts/ folder, why?

Cheers,
  Albert


> 
> Jonathan