karchive and QSaveFile

Boudewijn Rempt boud at valdyas.org
Sun Apr 2 19:04:11 BST 2017


On Sat, 1 Apr 2017, Sune Vuorela wrote:

> On 2017-03-28, Boudewijn Rempt <boud at valdyas.org> wrote:
> > I'm now wondering whether to hack QSaveFile's close to just not
> > abort, or add inherits("QSaveFile") checks all over KArchive --
> > or whether there's a third, better option that I've missed...
> 
> Without having put too much thought into it, add an "Don't close the
> device underlying device" boolean option to the relevant KArchive
> classes?

Logically, if I were to design the api from scratch, passing an io device
should mean "this is mine, keep your mittens off, don't close it", but that
would break so much existing code...

-- 
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org




More information about the kde-core-devel mailing list