Review Request 128941: ZLIB dependency is in libkonq since 7635179

[David Faure]

> On Sept. 19, 2016, 6:32 a.m., Sune Vuorela wrote:
> > konqueror/src/CMakeLists.txt, line 18
> > <https://git.reviewboard.kde.org/r/128941/diff/1/?file=477131#file477131line18>
> >
> >     I think the comment is wrong. I can't find any zlib references in konqueror itself.  Also note that the linkage is actually commented out.

Right, that's why his patch removes that comment ;-)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128941/#review99267
-----------------------------------------------------------


On Sept. 18, 2016, 11:36 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128941/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 11:36 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> builds and runs fine without the dependency
> 
> 
> Diffs
> -----
> 
>   konqueror/CMakeLists.txt 53c4829cbc2f8b380ad8608b555eb6e15b24a3bb 
>   konqueror/src/CMakeLists.txt e8e408611335fa56faf24466307f83e40a3b70ee 
>   lib/konq/CMakeLists.txt 7a61493ff13561340c1a6c114763489343212f41 
> 
> Diff: https://git.reviewboard.kde.org/r/128941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160919/cbfd57b4/attachment.htm>