Review Request 128737: Update second part of konqueror docbook to 16.12

David Faure faure at kde.org
Sun Sep 18 18:21:12 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128737/#review99255
-----------------------------------------------------------


Fix it, then Ship it!




Please push after the suggested fixes, I want to move doc/konqueror to konqueror/doc, to prepare for kde-baseapps being split up.
Thanks!


doc/konqueror/index.docbook (line 2011)
<https://git.reviewboard.kde.org/r/128737/#comment66833>

    Comment out the whole sidebar section, I'm not sure it'll ever exist again.



doc/konqueror/index.docbook (line 2311)
<https://git.reviewboard.kde.org/r/128737/#comment66834>

    typo: build -> built, but yeah, you can also just remove that section.



doc/konqueror/index.docbook (line 3635)
<https://git.reviewboard.kde.org/r/128737/#comment66835>

    typo: Thes -> These



doc/konqueror/index.docbook (line 4235)
<https://git.reviewboard.kde.org/r/128737/#comment66836>

    More typically, this would be ~/.local/share.
    
    If this says ~/.local for you, it means you have a XDG_DATA_HOME set to the wrong value (you can blame me for it, I wrote the wrong value in a kf5 setup wiki page long ago -- it's fixed since, but people still have an unusual setup due to that)



doc/konqueror/index.docbook (line 4257)
<https://git.reviewboard.kde.org/r/128737/#comment66837>

    These two don't exist anymore (even in kde4)


- David Faure


On Aug. 23, 2016, 4:35 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128737/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 4:35 p.m.)
> 
> 
> Review request for Documentation, KDE Base Apps and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> proofread + update
> replace common menu items with link to fundamentals
> 
> 
> Diffs
> -----
> 
>   doc/konqueror/index.docbook 00bfdfd 
> 
> Diff: https://git.reviewboard.kde.org/r/128737/diff/
> 
> 
> Testing
> -------
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160918/0a047b4f/attachment.htm>


More information about the kde-core-devel mailing list