Review Request 128909: initial, minimal support for OS X
thiago at kde.org
Thu Sep 15 05:22:48 BST 2016
On quarta-feira, 14 de setembro de 2016 17:58:26 PDT René J.V. Bertin wrote:
> > On Sept. 14, 2016, 7:33 p.m., Anthony Fieroni wrote:
> > > processcore/processes_darwin_p.cpp, line 104
> > > <https://git.reviewboard.kde.org/r/128909/diff/1/?file=476875#file476875
> > > line104>> >
> > > *inline* must be used in function definition not in declaration.
> I didn't see the point of the way the keyword is being used here either, but
> I aligned myself to the current practice.
> So I take it I shouldn't only correct `argMax()`?
It's all in the same .cpp, it doesn't matter. Inline is correct where it is.
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
More information about the kde-core-devel