Review Request 120127: Don't show overwrite dialog if file name is empty

Ignaz Forster prefix_kde at
Sat Oct 22 16:50:50 BST 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 22, 2016, 5:50 p.m.)


This change has been marked as submitted.

Review request for kdelibs.


Submitted with commit 0cc054d1c6336f1a4c7604d437d15de076a50293 by Albert Astals Cid on behalf of Ignaz Forster to branch KDE/4.14.

Repository: kdelibs


Programs using KFileDialog's setConfirmOverwrite(true) (e.g. LibreOffice with KDE4 integration, Mozilla products with KDE4 integration, several components of the PIM suite) will trigger the following strange behaviour:
If the file name in the save file dialog is empty and the user selects "Save", the dialog will ask if you want to overwrite the current directory (instead of just ignoring the empty input).

By moving the query below the directory checks the order is correct again, showing the overwrite confirmation dialog only if the field contains a unique filename.

Looking at the code this also affects Frameworks 5 / kio, though I haven't tested it yet.


  kfile/kfilewidget.cpp fc9b169 




Ignaz Forster

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list