Review Request 129208: Fix KUrl::isRelativeUrl to allow all RFC3986 characters in scheme.

[Gerhard Gappmeier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129208/
-----------------------------------------------------------

(Updated Oct. 22, 2016, 2:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and Thiago Macieira.


Changes
-------

Submitted with commit a0f36a80ac76a0b23f1bf53fc43bd6e8191048b1 by Albert Astals Cid on behalf of Gerhard Gappmeier to branch KDE/4.14.


Repository: kdelibs


Description
-------

RFC3986 defines the following syntax for URI schemes
scheme = alpha *( alpha | digit | "+" | "-" | "." )

The '.' was missing which leaded to the problem that
xdg-open opc.tcp://localhost didn't work.

Background:
xdg-open calls kde-open which then uses KUrl and so leaded to this
problem. Of course this bug may affect also many other locations
using KUrl::isRelativeUrl.

This fix also adds a unit test to test the fix and avoid future
regressions.


Diffs
-----

  kdecore/io/kurl.cpp d9661eab5f8df3bfbbd2900246437fb129037dba 
  kdecore/tests/kurltest.cpp 3947724bfd1d26ad69b97789205a814a8d712591 

Diff: https://git.reviewboard.kde.org/r/129208/diff/


Testing
-------


Thanks,

Gerhard Gappmeier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161022/a731c3bb/attachment.htm>