Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

[Andreas Sturmlechner]

> On Oct. 21, 2016, 5:59 a.m., Martin Gräßlin wrote:
> > I think that's too much a change for a bug-fix only library.

Is it, really? There's buildsystem changes only, akin to existing switches, and default shipment of kdelibs remains 100% the same, although arguably it's a bigger change than recent strigi optionalisation. The patch has been in use for several releases already, at least Fedora is doing something similar and Debian is also on the path to remove Qt4WebKit.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129233/#review100189
-----------------------------------------------------------


On Oct. 20, 2016, 8:50 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129233/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 8:50 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Provide a switch for distributions to disable build of kdewebkit and
> kdewebkit-widgets, to support efforts on getting rid of Qt4 WebKit.
> 
> The implications of this for KDE Applications packages are, at this
> point, negligible:
> 
> kde-runtime/drkonqi
> kde-runtime/kioslave (htmlthumbnail, removable with little effort)
> kde-runtime/plasma (with rdeps: kqtquickcharts, ktouch)
> pykde4 (with rdep: kajongg)
> 
> The following two listed for completeness, even if not part of
> current KDE Applications releases anymore:
> kdepim-4
> marble-4
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f1266655c512474626b68565a2830dae5828bf57 
>   kdewidgets/CMakeLists.txt 51536017ac0a3a86e164e30b80840a89aa3a8248 
>   plasma/CMakeLists.txt b9214388d72122ae9c5709b6956a8b8e13ccd3aa 
> 
> Diff: https://git.reviewboard.kde.org/r/129233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161021/f0f05b00/attachment.htm>