Review Request 128600: Support newer hunspell versions in FindHUNSPELL.cmake

Albert Astals Cid aacid at kde.org
Thu Oct 20 14:50:52 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128600/#review100179
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On Aug. 4, 2016, 1:58 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128600/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 1:58 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This is a "backport" of https://quickgit.kde.org/?p=lokalize.git&a=commitdiff&h=7aa9dafeb457ca3bc48a61c5dfa2e69b0ecdad6c in lokalize.
> 
> I have no idea if anything actually still uses this (lokalize has been ported to KF5 and comes with its own copy, the sonnet hunspell plugin in kdelibs is disabled), but it sure doesn't hurt to "fix" it anyway I think. ;-)
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindHUNSPELL.cmake 26942b5 
> 
> Diff: https://git.reviewboard.kde.org/r/128600/diff/
> 
> 
> Testing
> -------
> 
> Built lokalize 14.12.3 (still KDE4 based) with hunspell 1.4 successfully.
> Before, the build aborted because a suitable hunspell couldn't be found.
> 
> It also still builds fine with hunspell 1.3.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161020/36e427ef/attachment.htm>


More information about the kde-core-devel mailing list