Review Request 129219: Fix gcc 6.2 compile error.

[Albert Astals Cid]

> On Oct. 19, 2016, 9 a.m., Albert Astals Cid wrote:
> > I almost sure you're using an old kdelibs
> > 
> > https://github.com/KDE/kdelibs/commit/1e9ba7d00bb870c7f5b7d2af2ccd31799e1b1910 should fix that problem
> 
> Ralf Habacker wrote:
>     Thanks for this pointer. Taking a look at the implementation:  SHOW_ALL looks to be a bit mask of all defined constants, which is currently 0xfff. Is it guaranteed that static casting of 0xffffffff to int returns a valid bit mask in any case and on any compiler ? If so I will discard this request.

This fix has been there for two years in kjs, noone has complained, so it is the correct fix.

And if it's not, you have to bring it up in kjs

https://github.com/KDE/kjs/commit/dadacaf995170f44e6d392fce2c3f6c7e4967989


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129219/#review100130
-----------------------------------------------------------


On Oct. 19, 2016, 8:50 a.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129219/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 8:50 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This commit fixes the following error on compiling khtml/ecma/kjs_views.cpp
>  In file included from ...khtml/ecma/kjs_traversal.cpp:22:0:
>    ...build/khtml/kjs_traversal.lut.h:54:1: error: narrowing conversion
>      of '(DOM::NodeFilter::ShowCode)4294967295u' from 'unsigned int' to
>     'int' inside { } [-Wnarrowing]
> 
> 
> Diffs
> -----
> 
>   khtml/dom/dom2_traversal.h c09fd5525200648c2f65f8204e2dd03669635f23 
> 
> Diff: https://git.reviewboard.kde.org/r/129219/diff/
> 
> 
> Testing
> -------
> 
> Compiled with gcc 6.2 at https://build.opensuse.org/public/build/windows:mingw/openSUSE_Factory/x86_64/kdelibs4/_log
> 
> Bug has been detected with 4.14.10 and is not fixed in KDE/4.14 branch.
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161019/b8ba4a93/attachment.htm>