Review Request 129208: Fix KUrl::isRelativeUrl to allow all RFC3986 characters in scheme.

[Albert Astals Cid]

> On Oct. 17, 2016, 12:13 p.m., Aleix Pol Gonzalez wrote:
> > I'm not sure it's a very good idea to introduce behavior changes in kdelibs 4. Why can't you use kde-open from kf5?
> 
> Gerhard Gappmeier wrote:
>     Because I'm running KDE4 on many machines and want this bug fixed. It's not a solution to switch the newer OS and KDE version.
>     I think there are still many KDE4 users out there (debian wheezy).
>     Also I'm not sure if this is fixed in KF5. We should check that, but I don't have if it running here. Can you verify that this is fixed in KF5?
> 
> Aleix Pol Gonzalez wrote:
>     In KF5 this code moved to QUrl (KUrl is in KDELibs4Support there, not used by kde-open).

> Can you verify that this is fixed in KF5?

How would one test this from the user point of view (i.e using kde-open5)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129208/#review100093
-----------------------------------------------------------


On Oct. 17, 2016, 10:18 a.m., Gerhard Gappmeier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129208/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 10:18 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> RFC3986 defines the following syntax for URI schemes
> scheme = alpha *( alpha | digit | "+" | "-" | "." )
> 
> The '.' was missing which leaded to the problem that
> xdg-open opc.tcp://localhost didn't work.
> 
> Background:
> xdg-open calls kde-open which then uses KUrl and so leaded to this
> problem. Of course this bug may affect also many other locations
> using KUrl::isRelativeUrl.
> 
> This fix also adds a unit test to test the fix and avoid future
> regressions.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kurl.cpp d9661eab5f8df3bfbbd2900246437fb129037dba 
>   kdecore/tests/kurltest.cpp 3947724bfd1d26ad69b97789205a814a8d712591 
> 
> Diff: https://git.reviewboard.kde.org/r/129208/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gerhard Gappmeier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161018/3ce21ee0/attachment.htm>