Review Request 129121: [konqueror] Ability to navigate with mouse back/forward buttons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129121/#review99872
-----------------------------------------------------------


Ship it!




Thanks, I like this much better.

Only found minor styling issues, feel free to push either way.


konqueror/src/konqrmbeventfilter.h (line 37)
<https://git.reviewboard.kde.org/r/129121/#comment67104>

    while at it, remove virtual, add Q_DECL_OVERRIDE



konqueror/src/konqrmbeventfilter.cpp (line 61)
<https://git.reviewboard.kde.org/r/129121/#comment67102>

    I liked it better when it was called obj :)
    o is too short and can look like a 0.
    
    I know, the other is called "e", but nevermind that (it should be "ev" at least, but that requires renaming all the existing "ev" in the implementation). At least this one wasn't made worse by the patch ;)



konqueror/src/konqrmbeventfilter.cpp (line 74)
<https://git.reviewboard.kde.org/r/129121/#comment67103>

    We could have a parentWindow function just like the parentFrame function, to encapsulate the logic of how to go up from the frame to the window


- David Faure


On Oct. 9, 2016, 5:39 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129121/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2016, 5:39 a.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   konqueror/src/CMakeLists.txt fc1849b 
>   konqueror/src/konqmainwindow.cpp a3eddb1 
>   konqueror/src/konqrmbeventfilter.h 12c7a08 
>   konqueror/src/konqrmbeventfilter.cpp 6c2a195 
>   konqueror/src/konqueror.kcfg c53c326 
> 
> Diff: https://git.reviewboard.kde.org/r/129121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161009/ef25ff40/attachment.htm>