Review Request 129121: [konqueror] Ability to navigate with mouse back/forward buttons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129121/#review99854
-----------------------------------------------------------




konqueror/src/konqmainwindow.cpp (line 337)
<https://git.reviewboard.kde.org/r/129121/#comment67099>

    This will call the existing KonqMainWindow::eventFilter method in more cases than before. I'm wary of side effects, and it also means that if you have 5 mainwindows open in one process, one click on BackButton will go back in all 5 mainwindows. This doesn't seem very wise ;-)
    
    Please move this to KonqRmbEventFilter, which you should then rename to something slightly more generic like KonqMouseEventFilter. You can see there how "right click goes back" [a feature which I wouldn't mind removing, while at it...] is implemented (including finding the right KonqFrame where to go back), you can do something similar for back/forward buttons.
    (remove the if above installEventFilter and the install/remove logic in reparseConfiguration, of course, so that back/forward always work).


- David Faure


On Oct. 8, 2016, 12:07 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129121/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2016, 12:07 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp a3eddb1 
> 
> Diff: https://git.reviewboard.kde.org/r/129121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161008/e14a2955/attachment.htm>