Review Request 129114: [kdialog] Ability to read from stdin in textbox

David Faure faure at kde.org
Thu Oct 6 22:04:36 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129114/#review99831
-----------------------------------------------------------


Fix it, then Ship it!




Looks good.


kdialog/widgets.cpp (line 115)
<https://git.reviewboard.kde.org/r/129114/#comment67093>

    QLatin1String is better for a comparison


- David Faure


On Oct. 6, 2016, 5:57 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129114/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 5:57 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   kdialog/widgets.cpp 70f4258 
> 
> Diff: https://git.reviewboard.kde.org/r/129114/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161006/a932ee13/attachment.htm>


More information about the kde-core-devel mailing list