Review Request 128750: Fix compilation of kdecore
Lamarque Souza
lamarque at kde.org
Thu Oct 6 20:53:43 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128750/#review99830
-----------------------------------------------------------
Ship it!
Ship It!
- Lamarque Souza
On Aug. 24, 2016, 10:49 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128750/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 10:49 p.m.)
>
>
> Review request for kdelibs and Andrea Iacovitti.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Without this I get
>
> CMakeFiles/KF5Codecs.dir/kcharsets.cpp.o: In function `KCharsets::fromEntity(QString const&)':
> kcharsets.cpp:(.text+0x5cf): undefined reference to `kde_findEntity'
>
> Use gperf C++ generated code instead of C
>
> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41194 for more info
>
>
> Diffs
> -----
>
> kdecore/localization/kcharsets.cpp 5b72432
> kdecore/localization/kentities.cc 8c18351
> kdecore/localization/kentities.gperf 19522fe
>
> Diff: https://git.reviewboard.kde.org/r/128750/diff/
>
>
> Testing
> -------
>
> Compiles
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161006/f269ca0f/attachment.htm>
More information about the kde-core-devel
mailing list