Review Request 129423: keditbookmarks: add standard icons and shortcuts to Undo/Redo actions

Christoph Feck cfeck at kde.org
Fri Nov 18 12:45:30 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129423/#review100929
-----------------------------------------------------------


Ship it!




Ship It!

- Christoph Feck


On Nov. 18, 2016, 10:33 a.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129423/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2016, 10:33 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: keditbookmarks
> 
> 
> Description
> -------
> 
> These actions are created by QUndoStack in order that it can manage the action text.  However, this means that they do not get the standard KDE action icon or shortcuts set.  This change sets those by reference to the appropriate KStandardAction.
> 
> 
> Diffs
> -----
> 
>   src/kbookmarkmodel/commandhistory.cpp 53a8931 
> 
> Diff: https://git.reviewboard.kde.org/r/129423/diff/
> 
> 
> Testing
> -------
> 
> Built keditbookmarks (split repository master version) with this change, observed correct appearance and operation of Undo/Redo actions.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161118/769a4e80/attachment.htm>


More information about the kde-core-devel mailing list