Review Request 127629: Fix KDateTime::isValid() for ClockTime values

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127629/#review95193
-----------------------------------------------------------



Can I commit this?

- David Jarvie


On April 10, 2016, 6:43 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127629/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 6:43 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Bugs: 336738
>     https://bugs.kde.org/show_bug.cgi?id=336738
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> KDateTime::isValid() wrongly returns invalid for an instance which is specified in ClockTime, if the date/time is invalid in the local time zone. This is due to the internal QDateTime value being set to Qt::LocalTime, and unlike in Qt4, QDateTime in Qt5 uses the local time zone to validate the date/time. For ClockTime, there is no associated time zone (and choosing the local time zone to perform validation is purely arbitrary), so it should ignore the local time zone when validating.
> 
> 
> Diffs
> -----
> 
>   autotests/kdatetimetest.cpp a8e7749 
>   src/kdecore/kdatetime.cpp c530db1 
> 
> Diff: https://git.reviewboard.kde.org/r/127629/diff/
> 
> 
> Testing
> -------
> 
> Test added to kdatetimetest, all tests pass.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160504/b7fe325e/attachment.htm>