Review Request 127823: Allow building without strigi on Linux

Aleix Pol Gonzalez aleixpol at kde.org
Tue May 3 17:01:47 BST 2016



> On May 3, 2016, 2:58 p.m., Aleix Pol Gonzalez wrote:
> > Why touch the `if(WIN32)` though? If needed, just make it optional on all platforms.
> 
> Antonio Rojas wrote:
>     That's what I'm doing... Currently it's only optional on WIN32, I'm changing it to be optional regardless of the platform

Eh... fair enough.

+1


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127823/#review95136
-----------------------------------------------------------


On May 3, 2016, 2:06 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127823/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 2:06 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Now that kde-workspace is obsolete and kdelibs is only used by some still unported applications, it doesn't make sense to force using strigi anymore. This will allow dropping this old unmaintained library from distributions.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e7b2bea 
> 
> Diff: https://git.reviewboard.kde.org/r/127823/diff/
> 
> 
> Testing
> -------
> 
> Builds with and without strigi, everything seems to work
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160503/2b3a89ab/attachment.htm>


More information about the kde-core-devel mailing list