Review Request 127102: Use fixed width for digital clock applet

Martin Klapetek martin.klapetek at gmail.com
Tue Mar 15 21:41:54 GMT 2016



> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote:
> > I've tested it extensively and it works great. Thanks a lot!
> > 
> > There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the same font size should also be applied to the left date label (there are; the bottom should stay as is). Do you think you could include it as part of this patch?
> 
> Daniel Faust wrote:
>     I changed it, but now I'm not so sure anymore if the fixed font size wasn't intentional.
>     It would be a separate issue anyway and not connected to this one, so if you want, I can upload the patch to a new review request.

Yeah, that'd be great. Thanks!


> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568
> > <https://git.reviewboard.kde.org/r/127102/diff/3/?file=448492#file448492line565>
> >
> >     Can't we just compare "A" and "P" width's and use that? Would spare creating two Date objects and two calls to Qt.formatTime
> 
> Daniel Faust wrote:
>     No, because eg. in german the strings for am and pm are "vorm." and "nachm.".

Ah, good. Haven't thought of that. Those germans...

(on the other hand, I wouldn't expect anyone in Germany to actually not use 24h clock format, but oh well)

One other thing - create just a single Date object and then call setHours(13) on it for the second format.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93561
-----------------------------------------------------------


On March 8, 2016, 6:53 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127102/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 6:53 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 347724
>     https://bugs.kde.org/show_bug.cgi?id=347724
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently the width of the date label is not fixed but changes depending on the text. This causes the entire applet to change its width (if the time is the widest displayed item). This in turn can cause all other applets in the same panel to move whenever the displayed time changes.
> 
> This patch uses FontMetrics to iterate over all possible time strings (with different width) and chooses the widest of them as reference for the fixed width of the time label.
> 
> This way the width of the applet stays the same (unless the date is displayed and changes). The text remains centered though, which means that it can still move within the applet when the time changes.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127102/diff/
> 
> 
> Testing
> -------
> 
> Works with horizontal and vertical panel.
> Also displaying different combinations of "seconds", "date" and "timezone" works.
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160315/fbbb1045/attachment.htm>


More information about the kde-core-devel mailing list