Review Request 128102: Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( reproducible )

[Scarlett Clark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128102/
-----------------------------------------------------------

(Updated June 22, 2016, 3:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, kdelibs, David Faure, and Sune Vuorela.


Changes
-------

Submitted with commit d6655e34f05516b9e857e8b2e1a9238c33875924 by Scarlett Clark to branch KDE/4.14.


Repository: kdelibs


Description
-------

Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( reproducible builds )

Under certain locals non standard characters will get dropped making builds un reproducible. Setting the encoding to utf-8 
on the files makes all builds reproducible no matter what ( or none ) locale is in use. Thereby making the build reproducible.


Diffs
-----

  kdecore/kconfig_compiler/kconfig_compiler.cpp 30f52ab1 

Diff: https://git.reviewboard.kde.org/r/128102/diff/


Testing
-------

Built kdelibs then installed it, rebuilt chokoq with patched kdelibs and the build is now reproducible. There are likley other kde projects affected and will be fixed with this patch.
Thanks for your consideration.


Thanks,

Scarlett Clark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160622/c8e48dc2/attachment.htm>