Review Request 128160: Fix compilation with gcc6

[Heiko Becker]

> On Juni 12, 2016, 8:31 nachm., Albert Astals Cid wrote:
> > the file contains only whitespace changes. Is that right?
> > 
> > Also i can't find that commit in solid.
> 
> Nicolás Alvarez wrote:
>     Yes, that is right. `"foo"bar` is now interpreted as a C++11 user-defined string literal, and you need to add a space if you want it interpreted as `"foo"` compile-time concatenated with the expanded value of the macro `bar`.
> 
> Albert Astals Cid wrote:
>     Any idea where's the solid commit that Heiko mentions?
> 
> Heiko Becker wrote:
>     It's not in the solid repo but in the frameworks branch of the unsplitted kdelibs.
> 
> Albert Astals Cid wrote:
>     So solid does or does not need this fix?

Let me rephrase that: It was changed before solid was split out and the history of solid's own repo apparently starts with the split (although I guess I could get it with git graft).


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128160/#review96383
-----------------------------------------------------------


On Juni 12, 2016, 6:40 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128160/
> -----------------------------------------------------------
> 
> (Updated Juni 12, 2016, 6:40 nachm.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This basically backports 3c38c2bba3dc2313fa95ff99c76aae3870e0a168
> from solid.
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/shared/cpufeatures.cpp baa1af21098d7c312d7a9176e216d9d0f8e3a7a6 
> 
> Diff: https://git.reviewboard.kde.org/r/128160/diff/
> 
> 
> Testing
> -------
> 
> Not enough to successfully compile with gcc-6, but at least one error less.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160612/22b666d3/attachment.htm>