Review Request 128102: Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( reproducible )

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128102/#review96365
-----------------------------------------------------------



Have you tried if this is needed for the KDE Frameworks version of the kconfig_compiler?

- Albert Astals Cid


On jun. 12, 2016, 1:19 a.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128102/
> -----------------------------------------------------------
> 
> (Updated jun. 12, 2016, 1:19 a.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, David Faure, and Sune Vuorela.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( reproducible builds )
> 
> Under certain locals non standard characters will get dropped making builds un reproducible. Setting the encoding to utf-8 
> on the files makes all builds reproducible no matter what ( or none ) locale is in use. Thereby making the build reproducible.
> 
> 
> Diffs
> -----
> 
>   kdecore/kconfig_compiler/kconfig_compiler.cpp 30f52ab1 
> 
> Diff: https://git.reviewboard.kde.org/r/128102/diff/
> 
> 
> Testing
> -------
> 
> Built kdelibs then installed it, rebuilt chokoq with patched kdelibs and the build is now reproducible. There are likley other kde projects affected and will be fixed with this patch.
> Thanks for your consideration.
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160612/218a7f3f/attachment.htm>