Minuet (music education software) moved to kdereview
aleixpol at kde.org
Sun Jan 31 23:42:47 GMT 2016
On Mon, Feb 1, 2016 at 12:30 AM, Albert Astals Cid <aacid at kde.org> wrote:
> El Tuesday 26 January 2016, a les 10:15:47, Andreas Cord-Landwehr va escriure:
>> On Monday 25 January 2016 21:48:27 Albert Astals Cid wrote:
>> > El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va
>> > > * it looks strange to me that in minuet/cmake/ there are Config-files
>> > > for
>> > > the 3rd-party library drumstick. My understanding was that such Config
>> > > files should only be shipped with the respective library (maybe someone
>> > > with a deeper CMake-knowledge can comment?)
>> > If upstream ships a cmake file awesome, but if not then we have to find it
>> > having our own cmake file.
>> Absolutely, but shouldn't that be find-files then instead of config-files?
>> I always had the perception that those are quite different.
> Right, it most probably be a Find file not a Config file, as far as I
> understand it Config files are mostly for projects that ship the cmake file as
> part of their install.
> Can someone with more cmake knowledge comment?
Yes, the idea is that *Config.cmake files should be distributed by the
framework itself, otherwise you need to find it. It probably works
though, because such things are seldom checked within cmake though.
I suggest turning it into a normal Find*.cmake file. Or get Drumstick
to provide a cmake file, which is always more convenient.
More information about the kde-core-devel