Review Request 126851: Places data engine: Rename model role name "index" to "id"

Daniel Faust hessijames at
Wed Jan 27 10:34:41 GMT 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 27, 2016, 11:34 a.m.)


This change has been marked as submitted.

Review request for kde-workspace and Plasma.


Submitted with commit 8bedfde2894a60dc72a0bd40589dfb900776dace by Daniel Faust to branch master.

Repository: plasma-workspace


I wrote a qml applet using the places data engine and noticed that I can't access the index variable of ListView items because it gets overwritten by the places model.
This patch renames the "index" role name to "id" in order to avoid this naming conflict.


  dataengines/places/org.kde.places.operations 98a951d 
  dataengines/places/placeservice.cpp e0c93c5 
  dataengines/places/placesproxymodel.h 467fe83 
  dataengines/places/placesproxymodel.cpp 5ea807b 



I couldn't find any other model that is using the places data engine so I hope renaming the model role is fine.
The provided model still works and I tested the "Setup Device" and "Teardown Device" operations of the service.
The operations "Show" and "Hide" don't seem to work anyway and the others were not tested.


Daniel Faust

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
Plasma-devel mailing list
Plasma-devel at

More information about the kde-core-devel mailing list