Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

[Gregor Mi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/
-----------------------------------------------------------

(Updated Jan. 24, 2016, 11:09 a.m.)


Review request for KDE Base Apps, Martin Gräßlin, John Tapsell, and Thomas Pfeiffer.


Changes
-------

add 1 screenshot and 1 mockup


Repository: libksysguard


Description
-------

Current situation:
The "End Process..." button has a tooltip which says "To target a specific window to kill, press Ctrl+Alt+Esc at any time." The keyboard shortcut is hardcoded.

New:
Replace the "End Process..." button with a drop-down button and a action named "Kill a specific window..."


Diffs
-----

  CMakeLists.txt 66899e577a03786d894423a8f1ce5b3aeed6de8a 
  processui/CMakeLists.txt 7f87b85e0201e63d69070a71203bbb34851a79c6 
  processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3 
  processui/ksysguardprocesslist.cpp 450ca600b8aed7ca611ec638610b6c524c96080c 

Diff: https://git.reviewboard.kde.org/r/122249/diff/


Testing
-------


File Attachments (updated)
----------------

DEFERRED: New End Process button with drop down arrow
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
DEFERRED: new submenu
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/eeaecc88-20bc-46d6-9c65-50ba4a7c182a__submenu.png
Ctrl+Esc, currently
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/8d537357-1e08-4d67-8b45-28933c1a0ccf__screenshot_20160124_115024.png
Ctrl+Esc, with Tools... (menu contents see discussion)
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/71ebdcea-a793-460a-adb5-f05a7706f8b0__screenshot_20160124_115024-with-tools.png


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160124/155be9d0/attachment.htm>