Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

Aleix Pol Gonzalez aleixpol at kde.org
Sat Jan 16 17:11:32 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126704/#review91188
-----------------------------------------------------------


Fix it, then Ship it!




Fix copyright and push.


src/cursorthemesmodel.h (line 3)
<https://git.reviewboard.kde.org/r/126704/#comment62216>

    Fix copyright to your name and this year.



src/cursorthemesmodel.cpp (line 3)
<https://git.reviewboard.kde.org/r/126704/#comment62217>

    Copyright


- Aleix Pol Gonzalez


On Jan. 16, 2016, 5:14 p.m., Andrey Bondrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126704/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 5:14 p.m.)
> 
> 
> Review request for kde-workspace, Aleix Pol Gonzalez and Harald Sitter.
> 
> 
> Repository: kde-gtk-config
> 
> 
> Description
> -------
> 
> Implement changing cursor theme for GTK applications. It's needed to set cursor theme for Firefox and other applications that use GTK configs to set cursors.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 78814fc 
>   src/abstractappearance.h 378b71d 
>   src/abstractappearance.cpp 6d0dc27 
>   src/appearancegtk2.cpp b1e0b52 
>   src/appearancegtk3.cpp 5c481c9 
>   src/appearencegtk.h f797a08 
>   src/appearencegtk.cpp 9dee2d5 
>   src/cursorthemesmodel.h PRE-CREATION 
>   src/cursorthemesmodel.cpp PRE-CREATION 
>   src/gtkconfigkcmodule.h 032a5ef 
>   src/gtkconfigkcmodule.cpp 3d70f6e 
>   src/ui/gui.ui ebfacdf 
> 
> Diff: https://git.reviewboard.kde.org/r/126704/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local machine. Seems to do what it should properly.
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160116/3b1e0217/attachment.htm>


More information about the kde-core-devel mailing list