Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

[Andrey Bondrov]

> On Янв. 12, 2016, 12:11 п.п., Aleix Pol Gonzalez wrote:
> > All in all it looks quite good.
> > 
> > I'd suggest creating a CursorThemesModel inheriting IconThemesModel that overrides some methods (you can add virtuals). Otherwise we're adding weirdly specific logic.
> > 
> > Also I'd say it would be really good to be able to show some preview of the theme somehow, otherwise it's hard to tell them apart.
> 
> Andrey Bondrov wrote:
>     Yes, I'll do it.
> 
> Andrey Bondrov wrote:
>     Hmm, looks like there's no easy way to add previews for cursor files. KCM cursortheme from plasma-desktop uses xcb to load cursor files. Perhaps it's better to add it in another review request later.

Perhaps we need KF5Cursors framework to avoid duplicate code in kwin, plasma-desktop and kde-gtk-config. sddm-kcm also has own code to load cursors in src/cursortheme/


- Andrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126704/#review90964
-----------------------------------------------------------


On Янв. 13, 2016, 6:03 д.п., Andrey Bondrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126704/
> -----------------------------------------------------------
> 
> (Updated Янв. 13, 2016, 6:03 д.п.)
> 
> 
> Review request for kde-workspace, Aleix Pol Gonzalez and Harald Sitter.
> 
> 
> Repository: kde-gtk-config
> 
> 
> Description
> -------
> 
> Implement changing cursor theme for GTK applications. It's needed to set cursor theme for Firefox and other applications that use GTK configs to set cursors.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 78814fc 
>   src/abstractappearance.h 378b71d 
>   src/abstractappearance.cpp 6d0dc27 
>   src/appearancegtk2.cpp b1e0b52 
>   src/appearancegtk3.cpp 5c481c9 
>   src/appearencegtk.h f797a08 
>   src/appearencegtk.cpp 9dee2d5 
>   src/cursorthemesmodel.h PRE-CREATION 
>   src/cursorthemesmodel.cpp PRE-CREATION 
>   src/gtkconfigkcmodule.h 032a5ef 
>   src/gtkconfigkcmodule.cpp 3d70f6e 
>   src/ui/gui.ui ebfacdf 
> 
> Diff: https://git.reviewboard.kde.org/r/126704/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local machine. Seems to do what it should properly.
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160113/d02cae27/attachment.htm>