Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jan 12 12:11:49 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126704/#review90964
-----------------------------------------------------------


All in all it looks quite good.

I'd suggest creating a CursorThemesModel inheriting IconThemesModel that overrides some methods (you can add virtuals). Otherwise we're adding weirdly specific logic.

Also I'd say it would be really good to be able to show some preview of the theme somehow, otherwise it's hard to tell them apart.

- Aleix Pol Gonzalez


On Jan. 10, 2016, 2:43 p.m., Andrey Bondrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126704/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 2:43 p.m.)
> 
> 
> Review request for kde-workspace, Aleix Pol Gonzalez and Harald Sitter.
> 
> 
> Repository: kde-gtk-config
> 
> 
> Description
> -------
> 
> Implement changing cursor theme for GTK applications. It's needed to set cursor theme for Firefox and other applications that use GTK configs to set cursors.
> 
> 
> Diffs
> -----
> 
>   src/abstractappearance.h 378b71d 
>   src/abstractappearance.cpp 6d0dc27 
>   src/appearancegtk2.cpp b1e0b52 
>   src/appearancegtk3.cpp 5c481c9 
>   src/appearencegtk.h f797a08 
>   src/appearencegtk.cpp 9dee2d5 
>   src/gtkconfigkcmodule.h 032a5ef 
>   src/gtkconfigkcmodule.cpp 3d70f6e 
>   src/iconthemesmodel.h 2f0c453 
>   src/iconthemesmodel.cpp 07c7ad7 
>   src/ui/gui.ui ebfacdf 
> 
> Diff: https://git.reviewboard.kde.org/r/126704/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local machine. Seems to do what it should properly.
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160112/d4f88b74/attachment.htm>


More information about the kde-core-devel mailing list