Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/#review90743
-----------------------------------------------------------



src/ioslaves/ftp/ftp.cpp (line 1775)
<https://git.reviewboard.kde.org/r/126659/#comment62040>

    The porting bug is here. In kdelibs4 tmptr was initialized to the current date, and used below.
    
    Now we have two variables, "int year" and "currentTime.year".
    
    To be closer to the orig code and to avoid risking that the day or month is still 0 as well, I would suggest to initialize year, day and month directly from currentTime, rather than to 0.
    
    I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) because that's unused (right?)



src/ioslaves/ftp/ftp.cpp (line 1797)
<https://git.reviewboard.kde.org/r/126659/#comment62039>

    yes, this is a QDate behaviour change in Qt5.


- David Faure


On Jan. 7, 2016, 10 a.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126659/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 10 a.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Bugs: 354597
>     https://bugs.kde.org/show_bug.cgi?id=354597
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> - QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so subtracting 1900 is wrong.
> - in the case when no year is mentioned in the server's reply (the year is implicit), it wasn't set to the current year, so the result was either 0 or -1.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/ftp/ftp.cpp 2179179 
> 
> Diff: https://git.reviewboard.kde.org/r/126659/diff/
> 
> 
> Testing
> -------
> 
> Connected to an FTP server with dolphin (15.12.0). The modification times/dates are now shown correctly.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160107/3020e841/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel