Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

[Yichao Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126304/#review90551
-----------------------------------------------------------

Ship it!


LGTM other than the white space issue.


Sorry for the delay. I'm checking my email for the review requests but maybe I'm not using the right filter or not subscribing to the right list.....

- Yichao Yu


On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126304/
> -----------------------------------------------------------
> 
> (Updated 十二月 10, 2015, 12:12 p.m.)
> 
> 
> Review request for KDE Frameworks, Qt KDE and Yichao Yu.
> 
> 
> Repository: qtcurve
> 
> 
> Description
> -------
> 
> As the title says, this restores the definition of QTC_QT5_ENABLE_KDE in the CMake file when a KF5 build is done, and introduces the changes required for that build to succeed.
> 
> Except for removing references to the m_componentData member (already removed from the class; deprecated type) I have not made any other changes to the code.
> 
> 
> Diffs
> -----
> 
>   qt5/CMakeLists.txt 837d9c2 
>   qt5/style/CMakeLists.txt 7f65f8c 
>   qt5/style/qtcurve.cpp febcfcf 
>   qt5/style/qtcurve_api.cpp 87a927f 
>   qt5/style/qtcurve_p.h bfc7502 
>   qt5/style/qtcurve_primitive.cpp b5a3204 
> 
> Diff: https://git.reviewboard.kde.org/r/126304/diff/
> 
> 
> Testing
> -------
> 
> On KUbuntu 14.04 and Mac OS X 10.9.5, both with Qt 5.5.1 and KF5 Frameworks 5.16.0 installed under /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160104/12472e1b/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel