Review Request 127138: Konqueror: Fix window title showing as "/" when URL ends with that

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127138/
-----------------------------------------------------------

(Updated Feb. 23, 2016, 11:46 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Base Apps and David Faure.


Changes
-------

Submitted with commit f868ba3b34b4f55111c3b6fb1ff0e6bcaa1d2797 by Jonathan Marten to branch frameworks.


Repository: kde-baseapps


Description
-------

This happens when a local file URL which ends in "/" is navigated to.  For example, going to "/home/user" correctly shows "user" as the window title, while going to "/home/user/" shows "/" because the fileName() of that URL is empty.  This happens in particular when using the "Up" action, as it goes from "/home/user/foo" to "/home/user/".

This change ensures that trailing slashes are removed from URLs before using fileName() on them.


Diffs
-----

  konqueror/src/konqview.cpp 3707c7a 

Diff: https://git.reviewboard.kde.org/r/127138/diff/


Testing
-------

Built kde-baseapps with these changes, observed correct display of base name in Konqueror window title while navigating.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160223/23c53862/attachment.htm>