Review Request 127006: konqueror: eliminate signal and shortcut warnings

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127006/
-----------------------------------------------------------

(Updated Feb. 22, 2016, 2:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Base Apps.


Changes
-------

Submitted with commit fc5e0160d81c4fad2e54e2cf31e09395634d7783 by Jonathan Marten to branch frameworks.


Repository: kde-baseapps


Description
-------

These changes to Konqueror's setting up of actions eliminate the runtime debug messages:

konqueror(3420)/default err_method_notfound: QObject::connect: No such signal QAction::triggered(Qt::MouseButtons,Qt::KeyboardModifiers) in /ws/frameworks/applications/kdebaseapps/konqueror/src/konqmainwindow.cpp:3637

and one for each action:

konqueror(3420)/default KXMLGUIFactoryPrivate::saveDefaultActionProperties: Shortcut for action  "new_window" "New &Window" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.

and also a number of compiler warnings:

konqueror/src/konqmainwindow.cpp:3705: warning: ‘KShortcut’ is deprecated


Diffs
-----

  konqueror/src/konqmainwindow.cpp c7a81c8 

Diff: https://git.reviewboard.kde.org/r/127006/diff/


Testing
-------

Built Konqueror with these changes.  Observed absence of those compiler and runtime error messages, checked correct operation of key shortcuts.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160222/10781b42/attachment.htm>