Review Request 104960: KJS: fix behaviour on allocation errors

Rolf Eike Beer kde at opensource.sf-tec.de
Sun Feb 7 17:29:24 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/104960/
-----------------------------------------------------------

(Updated Feb. 7, 2016, 5:29 nachm.)


Status
------

This change has been discarded.


Review request for kdelibs.


Repository: kdelibs


Description
-------

The KJS allocator will likely crash with a 0-deref on allocation errors. The exact behaviour will also depend on the platform, e.g. a Un*x platform without posix_memalign() will have MAP_FAILED as the pointer used for calculations (which is (void*)-1), other will have 0.

This will make the allocator have a sane default behaviour: just return 0.


Diffs
-----

  kjs/collector.cpp 70e4757 

Diff: https://git.reviewboard.kde.org/r/104960/diff/


Testing
-------


Thanks,

Rolf Eike Beer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160207/15207311/attachment.htm>


More information about the kde-core-devel mailing list