Review Request 129448: Dolphin Part: Fix problem with Konqueror paste action

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129448/#review101304
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On Nov. 20, 2016, 3:23 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129448/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2016, 3:23 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Bugs: 369523
>     https://bugs.kde.org/show_bug.cgi?id=369523
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> When Konqueror is being used as a file manager, the enable state of its "paste" action is not being correctly updated when changing to or showing a new directory.  More information is in the bug report, but what seems to be happening is that Dolphin as an application updates the state of its paste action both at the beginning of a directory listing operation and at the end.  Only at the latter time is the paste information correctly up to date.  When Konqueror uses the Dolphin part, its paste action is only updated at the beginning of a listing, which does not reflect the correct state.
> 
> This change connects an additional signal within the part so that the paste action is correctly updated at the end of the listing.  It does not affect Dolphin the application, because that does not use itself as a part.
> 
> 
> Diffs
> -----
> 
>   src/dolphinpart.cpp aa9ab298 
> 
> Diff: https://git.reviewboard.kde.org/r/129448/diff/
> 
> 
> Testing
> -------
> 
> Built Dolphin and Konqueror with this change, checked correct operation and enable state of the paste action when changing directories and between applications.  Also verified by bug submitter.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161205/ba696cc3/attachment.htm>