Review Request 128749: Backport karchive fix for out of directory files
Andreas Cord-Landwehr
cordlandwehr at kde.org
Thu Aug 25 17:45:58 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128749/#review98647
-----------------------------------------------------------
Ship it!
Yeah, thanks applying it!
LGTM, only point is that I cannot see the test-tar archive in the diff, but I presume that reviewboard cannot display binary files
- Andreas Cord-Landwehr
On Aug. 24, 2016, 10:36 nachm., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128749/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 10:36 nachm.)
>
>
> Review request for kdelibs, Andreas Cord-Landwehr and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> What the summary says
>
>
> Diffs
> -----
>
> kdecore/io/karchive.cpp eb0bf2e
> kdecore/tests/karchivetest.h e64e0ed
> kdecore/tests/karchivetest.cpp 7786b98
>
> Diff: https://git.reviewboard.kde.org/r/128749/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160825/3c9140e3/attachment.htm>
More information about the kde-core-devel
mailing list