Review Request 128697: Fix wrong value of __KDE_HAVE_GCC_VISIBILITY on systems with gcc 6.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128697/
-----------------------------------------------------------

(Updated Aug. 16, 2016, 2:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and Allen Winter.


Changes
-------

Submitted with commit e9b25c7c040d8526fe8675b97d1067c8ffa7249f by David Faure to branch KDE/4.14.


Repository: kdelibs


Description
-------

Clearly the author of this regexp, in 2006, thought gcc would never
hit version 6 :-)


Diffs
-----

  cmake/modules/FindKDE4Internal.cmake 7d54b9b83b999f6a6e8541f8e8b89e0b2a105703 

Diff: https://git.reviewboard.kde.org/r/128697/diff/


Testing
-------

Before:

kdemacros:/* #undef __KDE_HAVE_GCC_VISIBILITY */

After:

kdemacros.h:#define __KDE_HAVE_GCC_VISIBILITY


The impact of this was that symbols were no longer exported in shared libs that use the KDE_EXPORT macro, thus breaking linking.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160816/d9c155c9/attachment.htm>