Review Request 127393: digital-clock: Fix font size of date label in small panels
Daniel Faust
hessijames at mailbox.org
Sat Apr 9 11:12:28 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127393/
-----------------------------------------------------------
(Updated April 9, 2016, 12:12 nachm.)
Status
------
This change has been discarded.
Review request for kde-workspace.
Bugs: 360059
https://bugs.kde.org/show_bug.cgi?id=360059
Repository: plasma-workspace
Description
-------
Currently the digital clock applet uses a fixed font size for the date label when it's placed in a narrow horizontal panel.
Example: http://paste.opensuse.org/view/raw/f8ba5d0d
With this patch the same font size is used as for the time label.
As mentioned at https://git.reviewboard.kde.org/r/127102/ I'm not sure if the current design is a bug or intentional.
On the one hand having a smaller font size reduces the width of the applet, on the other hand having the same font size is more consistent.
I would prefer a consistent look however.
This patch creates one problem though. Currently the height of the date-time-separator is set to the height of the (fixed) date label font size.
With this patch I set the separator height to 70% of the applet height.
Diffs
-----
applets/digital-clock/package/contents/ui/DigitalClock.qml 02d55a9
Diff: https://git.reviewboard.kde.org/r/127393/diff/
Testing
-------
Thanks,
Daniel Faust
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160409/ea27c9e6/attachment.htm>
More information about the kde-core-devel
mailing list