Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

[Albert Astals Cid]

> On set. 17, 2015, 10:17 p.m., Albert Astals Cid wrote:
> > shell/shell.cpp, line 99
> > <https://git.reviewboard.kde.org/r/125297/diff/3/?file=404615#file404615line99>
> >
> >     I'd actually prefer if you fixed DnD as the fixme says instead of removing the feature.
> 
> Jeremy Whiting wrote:
>     Dragging and dropping of tabs is working fine with QTabBar as is.

but it's dropping of urls, not tabs, so basically dropping a file from dolphin.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125297/#review85593
-----------------------------------------------------------


On set. 17, 2015, 9:46 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125297/
> -----------------------------------------------------------
> 
> (Updated set. 17, 2015, 9:46 p.m.)
> 
> 
> Review request for kdelibs and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> When running the mainshelltest the tests that fail report being unable to call openDocument because of it's QUrl parameter. With this it no longer complains about that (but the tests still fail).
> 
> 
> Diffs
> -----
> 
>   shell/okular_main.cpp 1c988d9 
>   shell/shell.h c16a0b2 
>   shell/shell.cpp d0204f9 
> 
> Diff: https://git.reviewboard.kde.org/r/125297/diff/
> 
> 
> Testing
> -------
> 
> Test no longer complains about being unable to call openDocument.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150917/58ef4d8d/attachment.htm>