Review Request 125097: Icons for hiding/unhiding files

[andreas kainz]

> On Sept. 10, 2015, 9:29 p.m., andreas kainz wrote:
> > hi, we have 
> > hint https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/hint.svg and
> > visibility https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/visibility.svg
> > in the kde:breeze Plasma/5.4 brunch and on 13.09. in master.
> 
> Roman Gilg wrote:
>     Hi! Were these icons already planned for this switch? To be honest, I normally wouldn't care which icong goes there, I just want an icon there. But one thing makes me a little doubtful about these icons: Don't you think an eye, striked or not, always starring at you from the top of the file explorer will be a little disturbing? Especially when you increase the size of the icons.
>     But if the dolphin devs want this icon or you more (I don't know who decides this), I would change my other review request and link to thes icons instead. :)

I discussed it with Uri the main icon designer. he would prefere the hint icon. the icon from Roman is good but it could also be an cut icon.


- andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125097/#review85144
-----------------------------------------------------------


On Sept. 10, 2015, 8:19 p.m., Roman Gilg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125097/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 8:19 p.m.)
> 
> 
> Review request for kde-workspace, andreas kainz and Emmanuel Pescosta.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Icon is based on 'edit-copy.svg'. This icon is a follow up to my first review request https://git.reviewboard.kde.org/r/125094/
> which I opened because Dolphin missed an icon for its switch to see hidden files.
> 
> 
> Diffs
> -----
> 
>   icons-dark/actions/22/hidden-files.svg PRE-CREATION 
>   icons/actions/16/hidden-files.svg PRE-CREATION 
>   icons/actions/22/hidden-files.svg PRE-CREATION 
>   icons-dark/actions/16/hidden-files.svg PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125097/diff/
> 
> 
> Testing
> -------
> 
> Tested on Arch, Plasma 5.4.
> 
> 
> File Attachments
> ----------------
> 
> Demonstration in Breeze
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/9e208176-204f-4ab1-8fd5-6eef57bc10f4__change.png
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150910/8f13f939/attachment.htm>