Review Request 125081: Fix build on OS X

[Albert Astals Cid]

> On set. 6, 2015, 10:52 p.m., Albert Astals Cid wrote:
> > include config-kwindowsystem.h and use KWINDOWSYSTEM_HAVE_X11?
> 
> Samuel Gaist wrote:
>     And move all X11 related includes together ?

I'd only put netw.h there since it's the one that clearly comes from kwindowsystem having x11 support, no?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125081/#review84924
-----------------------------------------------------------


On set. 7, 2015, 5:50 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125081/
> -----------------------------------------------------------
> 
> (Updated set. 7, 2015, 5:50 p.m.)
> 
> 
> Review request for KDE Base Apps and Martin Gräßlin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Move netwm.h include under Q_WS_X11 since that header is made available with the xcb plugin.
> 
> 
> added .reviewboardrc
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   konqueror/src/konqmainwindow.cpp c7a81c8 
> 
> Diff: https://git.reviewboard.kde.org/r/125081/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150907/8c9eb820/attachment.htm>