Review Request 125010: konq-plugins: port kttsd plugin to QtSpeech

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125010/#review84941
-----------------------------------------------------------

Ship it!


Ah, sorry. I skipped reviewing that one because I was thinking "well, I don't know anything about QtSpeech. But indeed the QtSpeec part of it is a trivial two-liner :-)


konq-plugins/CMakeLists.txt (line 21)
<https://git.reviewboard.kde.org/r/125010/#comment58754>

    using macro_log_feature would be better



konq-plugins/ttsplugin/khtmltts.cpp (line 30)
<https://git.reviewboard.kde.org/r/125010/#comment58753>

    unused



konq-plugins/ttsplugin/khtmltts.cpp (line 51)
<https://git.reviewboard.kde.org/r/125010/#comment58752>

    This line seems unused (in which case, remove the comment for it too).


- David Faure


On Sept. 1, 2015, 2:23 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125010/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 2:23 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Ported kttsd plugin to QtSpeech.
> 
> 
> Diffs
> -----
> 
>   konq-plugins/CMakeLists.txt 1d74e91 
>   konq-plugins/kttsplugin/CMakeLists.txt 2faa7e6 
>   konq-plugins/kttsplugin/Messages.sh 3c21b1c 
>   konq-plugins/kttsplugin/khtmlkttsd.cpp c361321 
>   konq-plugins/kttsplugin/khtmlkttsd.desktop cb0a4bd 
>   konq-plugins/kttsplugin/khtmlkttsd.h 99bc848 
>   konq-plugins/kttsplugin/khtmlkttsd.rc 75a2c49 
>   konq-plugins/ttsplugin/CMakeLists.txt PRE-CREATION 
>   konq-plugins/ttsplugin/Messages.sh PRE-CREATION 
>   konq-plugins/ttsplugin/khtmltts.cpp PRE-CREATION 
>   konq-plugins/ttsplugin/khtmltts.desktop PRE-CREATION 
>   konq-plugins/ttsplugin/khtmltts.h PRE-CREATION 
>   konq-plugins/ttsplugin/khtmltts.rc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125010/diff/
> 
> 
> Testing
> -------
> 
> Builds, and works (wow I haven't ran konqueror in ages...)
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150907/8014f741/attachment.htm>