Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM
René J.V. Bertin
rjvbertin-Re5JQEeQqe8AvxtiuMwx3w at public.gmane.org
Fri Sep 4 12:53:00 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125043/#review84816
-----------------------------------------------------------
kcontrol/input/mouse.cpp (lines 183 - 185)
<https://git.reviewboard.kde.org/r/125043/#comment58700>
It is probably not required to use a dedicated change handler, correct?
- René J.V. Bertin
On Sept. 4, 2015, 1:51 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125043/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 1:51 p.m.)
>
>
> Review request for KDE Software on Mac OS X, kde-workspace and kdelibs.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> KDE4 has been providing a setting that (would have) allowed to avoid unwanted text zooming during simulated inertial scrolling (scroll coasting). KDE PIM applications were immune to that issue because certain KDELibs classes use the parameter, which made it all the more annoying that other (e.g. Kate-based) applications weren't. Sadly this setting wasn't published via a GUI.
>
> This patch adds a checkbox to the input ("mouse") KCM which seemed like the most appropriate place if not only because it also makes sense to provide this KCM on non-X11 platforms like OS X and MS Windows (where settings like "double or single click" are relevant).
>
> I consider this a fix of an omission bug, but I realise that it could also be considered a new feature, so this RR is also intended to give some public exposure to my patch rather than keeping it to myself.
>
>
> Diffs
> -----
>
> kcontrol/input/kmousedlg.ui b48a606
> kcontrol/input/mouse.h d926a99
> kcontrol/input/mouse.cpp cebb174
>
> Diff: https://git.reviewboard.kde.org/r/125043/diff/
>
>
> Testing
> -------
>
> For now only on OS X with kdelibs 4.14.11 .
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150904/54b5575b/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-mac at kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
More information about the kde-core-devel
mailing list