Review Request 125816: Allow building KF5::ProcessUi without QtWebkit

[Alex Richardson]

> On Oct. 27, 2015, 1:19 p.m., Christoph Feck wrote:
> > One script is used to show detailed memory information (which I find rather useful). We could use QtWebEngine when QtWebKit is not available.
> 
> Christoph Feck wrote:
>     ... or QTextBrowser

I agree that it is very useful, but I am currently compiling all of KF5 on a new system and I really don't want to build QtWebkit.
QtWebKit is declared as a optional dependency but actually it is pretty much required as without processui plasma-workspace can't be built.
If it is optional I think losing a bit of functionality is acceptable and otherwise we should declare it as required (or port to an alternative implementation)


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125816/#review87517
-----------------------------------------------------------


On Oct. 27, 2015, 12:20 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125816/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 12:20 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> The scripting feature will not be available but everything else will still
> work.
> 
> If we completely skip building processui plasma-workspace will fail halfway
> through the build (not a CMake time!) because -lKF5::ProcessUi cannot be
> found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 14d32d9453dd5e8bd71af9051585db245791d691 
>   config-ksysguard.h.cmake d95e1f570d835da92f5fa7e2835608fb85c9e9eb 
>   processui/CMakeLists.txt 7f87b85e0201e63d69070a71203bbb34851a79c6 
>   processui/scripting.cpp efed8ff66f5442f4d86a1a964977e856b632ff52 
> 
> Diff: https://git.reviewboard.kde.org/r/125816/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151027/10e01cd0/attachment.htm>